Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http byte range support #61

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: http byte range support #61

merged 1 commit into from
Sep 10, 2024

Conversation

alanshaw
Copy link
Member

Adds HTTP byte range support for UnixFS files.

Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just curious -- technically I thinkRange supposed to work for suffix without a total length. Not super duper important -- you could just sub entry.size if it's not given. Also technically range supports multiple -- I think only supporting one is useful.

@hannahhoward
Copy link
Member

Assume we built range support for trustless?

@alanshaw
Copy link
Member Author

Suffix support is in there!

Range support was already in ipfs-unixfs-exporter - we built range support for trustless gateway (dagula implements this) but this is not used here.

@alanshaw alanshaw merged commit 5be9a70 into main Sep 10, 2024
1 check passed
@alanshaw alanshaw deleted the feat/byte-range-support branch September 10, 2024 11:25
@alanshaw
Copy link
Member Author

closes #12

alanshaw pushed a commit that referenced this pull request Sep 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.1.0](v5.0.1...v5.1.0)
(2024-09-10)


### Features

* http byte range support
([#61](#61))
([5be9a70](5be9a70))


### Bug Fixes

* release please perms
([67cfd95](67cfd95))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants